This is an automated email from the ASF dual-hosted git repository.

driazati pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git


The following commit(s) were added to refs/heads/main by this push:
     new f0650986ad Revert "[CI] Fix build android rpc failure in CI" (#12277)
f0650986ad is described below

commit f0650986ad59efdda18a53b976e63c2f5055d4b5
Author: Matveenko Valery <[email protected]>
AuthorDate: Tue Aug 2 23:24:06 2022 +0200

    Revert "[CI] Fix build android rpc failure in CI" (#12277)
    
    Reverts apache/tvm#12216
    
    Addition to my previous changes.
    After the previous changes, the android camera build failed because by 
default `PYTHONPATH` is empty, and after `set -eux` it is fails:
    
https://github.com/apache/tvm/blob/759a648cd5237885a8205b1ee4508dabcc3af2d5/.github/workflows/main.yml#L152-L156
    
    This error was not noticed because the flag `continue-on-error` is true.
---
 .github/workflows/main.yml | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 71558c2050..ee2f351795 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -121,39 +121,34 @@ jobs:
           make jvmpkg
       - name: Build android_rpc
         working-directory: apps/android_rpc
-        continue-on-error: true
         run: |
           set -eux
           export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH"
           gradle clean build
       - name: Upload android_rpc APK
         uses: actions/upload-artifact@v2
-        continue-on-error: true
         with:
           name: android_rpc-debug.apk
           path: ./apps/android_rpc/app/build/outputs/apk/debug/app-debug.apk
       - name: Build android_deploy
         working-directory: apps/android_deploy
-        continue-on-error: true
         run: |
           set -eux
           export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH"
           gradle clean build
       - name: Upload android_deploy APK
         uses: actions/upload-artifact@v2
-        continue-on-error: true
         with:
           name: android_deploy-debug.apk
           path: ./apps/android_deploy/app/build/outputs/apk/debug/app-debug.apk
       - name: Build android_camera
         working-directory: apps/android_camera
-        continue-on-error: true
         run: |
+          export TVM_HOME=~/work/tvm/tvm
+          export PYTHONPATH=$TVM_HOME/python:${PYTHONPATH}
           set -eux
           mkdir -p app/src/main/assets/models/
           export 
TVM_NDK_CC=${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang++
-          export TVM_HOME=~/work/tvm/tvm
-          export PYTHONPATH=$TVM_HOME/python:${PYTHONPATH}
           python3 ${TVM_HOME}/python/gen_requirements.py
           pip3 install -r ${TVM_HOME}/python/requirements/core.txt
           cd models
@@ -164,7 +159,6 @@ jobs:
           gradle clean build
       - name: Upload android_camera APK
         uses: actions/upload-artifact@v2
-        continue-on-error: true
         with:
           name: android_camera-debug.apk
           path: ./apps/android_camera/app/build/outputs/apk/debug/app-debug.apk
\ No newline at end of file

Reply via email to