MichaelJKlaiber commented on PR #12087:
URL: https://github.com/apache/tvm/pull/12087#issuecomment-1203599874
Thanks to all the reviewers for the thorough reviews and the great
suggestions and comment that improved UMA!
@manupa-arm @areusch @sunggg @cbalint13 @kslavka @lhutton1
We integrated the vast majority of the requests in this review into the PR.
There were many **great suggestion** that we hadn't considered before, but
improved the overall quality of the UMA contribution, e.g.
- Tutorial as RST for gallery
- Adding a case test case where the TVM default pipeline and the UMA
pipeline are both used
- ...
This PR has been open for a quite long time now, it has improved steadily
and we feel that it is ready now. **Please let us know you thoughts.**
There are a couple of (small) things we left out for the is PR, and would
ask for you opinion to move it to (very near future) PRs:
- move OutlineCompilerFunctionsMutator out of UMA @areusch @manupa-arm
- replace AOTTestRunner by project API @manupa-arm
- annotations of UMALower._operator_strategies @lhutton1
(these steps will be moved to the tracking issue, for the case that the PR
is granted)
Further steps see current tracking issue
https://github.com/apache/tvm/issues/11260
CC: @SebastianBoblest @UlrikHjort
It is also great that WE as a community identified items where further
discussion is required, e.g.:
- UMA CLI / tvmc integration
- Demo use-cases, e.g. running BERT on Ethos-U with UMA
- ...
I'd move them to an updated version of the UMA RFC or the discussion forum
Thanks to everyone contributing to UMA, esp @cgerum @PaulPalomeroBernardo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
