driazati commented on code in PR #12125:
URL: https://github.com/apache/tvm/pull/12125#discussion_r943983138
##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -578,49 +623,78 @@ def generate_project(self, model_library_format_path,
standalone_crt_dir, projec
def build(self, options):
BUILD_DIR.mkdir()
- check_call(["cmake", ".."], cwd=BUILD_DIR)
+ zephyr_board = _find_board_from_cmake_file(API_SERVER_DIR /
CMAKELIST_FILENAME)
+ emu_platform = _find_platform_from_cmake_file(API_SERVER_DIR /
CMAKELIST_FILENAME)
+
+ env = dict(os.environ)
+ if self._is_fvp(zephyr_board, emu_platform == "armfvp"):
+ env["ARMFVP_BIN_PATH"] = str(API_SERVER_DIR / "fvp-hack")
Review Comment:
If the script gets sent between a build and a test step in Jenkins it goes
through AWS S3 which doesn't have any notion of file permissions, so we add
them back in here:
https://github.com/apache/tvm/blob/main/ci/jenkins/Build.groovy.j2#L36-L43.
Changing that is a little tricky since those changes wont be run in CI unless
the source branch is under apache/tvm and not from a fork, so keeping the chmod
in code here seems reasonable for now. We can follow up with a change that
cleans it up and moves it out to `Build.groovy.j2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
