ashutosh-arm commented on code in PR #12353:
URL: https://github.com/apache/tvm/pull/12353#discussion_r944013801
##########
tests/python/contrib/test_cmsisnn/test_conv2d.py:
##########
@@ -729,7 +830,7 @@ def test_invalid_parameters(
in_dtype,
kernel_dtype,
in_dtype,
- False,
+ is_depthwise=False,
)
model, params = make_model(
shape=ifm_shape,
Review Comment:
Added two tests: test_invalid_pad_conv2d_fusion_int8 and
test_pad_conv2d_fusion_int8. For the invalid padding cases, I had to introduce
another pattern checker named check_qnn_conv2d_pad() in cmsisnn.py without
which it defaults to including pads in the pattern.
##########
src/relay/backend/contrib/cmsisnn/fuse_pads.cc:
##########
@@ -0,0 +1,219 @@
+
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
