mehrdadh opened a new issue, #12409:
URL: https://github.com/apache/tvm/issues/12409
example:
```
target = tvm.target.Target("llvm -link-params=1")
executor = Executor("aot")
```
This will result in this executor: `graph{"link-params": 1}`
I looked at the logic of `_reconstruct_from_deprecated_options`, the issue
is that if the executor config is not part of the target it will assume `graph`
by default. This is obviously incorrect.
Possible solutions
- Pass `executor` to `_reconstruct_from_deprecated_options` and derive the
final executor considering the original executor that was passed to build.
- Remove this function and instead show runtime error when wrong config is
passed.
I suggest the second approach because the first approach is fairly
complicated considering the number of configs and most likely it will result in
wrong combination. This could be really annoying considering the fact that you
could end up building with incorrect executor without noticing.
thoughts?
cc @areusch @Mousius
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
