masahi commented on code in PR #12489:
URL: https://github.com/apache/tvm/pull/12489#discussion_r949059851


##########
src/relay/backend/task_extraction.cc:
##########
@@ -42,6 +43,14 @@ Array<meta_schedule::ExtractedTask> ExtractTask(
   // is_vm=true for backward compatibility
   Array<Pass> pass_seqs = 
relay::backend::GetPassPrefix(/*is_homogenous=*/true, /*is_vm=*/true);
   pass_seqs.push_back(transform::FuseOps());
+
+  if (auto link_params_obj = target->attrs.Get("link-params")) {
+    ICHECK(link_params_obj.as<IntImmNode>());
+    int link_params = link_params_obj.as<IntImmNode>()->value;
+    auto ctx = transform::PassContext::Current();
+    ctx->config.Set("relay.FuseOps.link_params", IntImm(DataType::Int(32), 
link_params));
+  }

Review Comment:
   The reason for this change is explained in 
https://github.com/apache/tvm/pull/12416#issuecomment-1219282120.
   
   It depends on soon-to-be deprecated target option. So this change could be 
controversial. 
   
   If I cannot depend on the value of `link-params` attribute from the target 
option, I have to pass `executor` to task extraction. This involves breaking 
API change. cc @junrushao1994 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to