areusch commented on code in PR #12440:
URL: https://github.com/apache/tvm/pull/12440#discussion_r951672131
##########
tests/cpp/target_test.cc:
##########
@@ -289,6 +291,45 @@ TEST(TargetCreation, ProcessStrings) {
ASSERT_EQ(array7[1][1][0], "fred");
}
+TEST(TargetCreation, LLVMCommandLineFatal) {
Review Comment:
just documenting offline convo: i think it would improve the PR to add a few
more unit tests. @kparzysz-quic pointed out this test case contains several
examples of bad options; action item is to move the various "bad options" in
this test case into separate test cases to increase coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
