apeskov commented on code in PR #12323:
URL: https://github.com/apache/tvm/pull/12323#discussion_r952377650
##########
src/runtime/vm/memory_manager.cc:
##########
@@ -105,15 +105,16 @@ NDArray StorageObj::AllocNDArray(size_t offset,
std::vector<int64_t> shape, DLDa
return ret;
}
-MemoryManager* MemoryManager::Global() {
+std::shared_ptr<MemoryManager> MemoryManager::Global() {
Review Comment:
"Global" means global. Thread local object is not obvious behaviour for this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
