farshidsp commented on code in PR #12504: URL: https://github.com/apache/tvm/pull/12504#discussion_r952972379
########## python/tvm/contrib/hexagon/pytest_plugin.py: ########## @@ -56,14 +56,19 @@ def _compose(args, decs): requires_hexagon_toolchain = tvm.testing.requires_hexagon(support_required="compile-only") [email protected](scope="session") def android_serial_number() -> Optional[str]: + """Return the android serial number or simulator""" serial = os.getenv(ANDROID_SERIAL_NUMBER, default="") # Setting ANDROID_SERIAL_NUMBER to an empty string should be # equivalent to having it unset. if not serial.strip(): serial = None - return serial + if serial == "simulator": + return serial + else: + # Split android serial numbers into a list + serial = serial.split(",") Review Comment: If the serial was set to None, we skip the test with a message that says android serial number is not set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
