mbaret commented on PR #12550: URL: https://github.com/apache/tvm/pull/12550#issuecomment-1225584960
> It'd be good to split out the `ExprAllocator` pass and test it independently I did consider this, but sided against it on the basis that `ExprAllocator` is an implementation detail of `AOTMainLowerer`. We should still be able to test all the behaviours implemented by `ExprAllocator` through the stable interface of `AOTMainLowerer`. I accept there are some conflicting testing philosophies around this though (I think BDD vs. TDD being the relevant one here), and so am open to other views. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
