mbaret commented on PR #12550: URL: https://github.com/apache/tvm/pull/12550#issuecomment-1225871160
At the end of the day, I think we're debating whether or not to test internal optimizations for what is essentially performance benefit. I'm especially wary to set precedent here because this very refactor would have been made a lot harder if extensive testing of internal implementation existed. I appreciate this is effectively down to personal preference given no strict ruling in the code quality guidelines around acceptable coverage, and that makes discussions like this hard to progress. In the spirit of [Consensus Building](https://github.com/apache/tvm/blob/main/docs/contribute/code_review.rst#consensus-building), perhaps we can wait and see if there's any other input given I think we've both presented the extent of our arguments at this stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
