rebel-jaehunryu commented on code in PR #11499:
URL: https://github.com/apache/tvm/pull/11499#discussion_r956985212
##########
python/tvm/driver/build_module.py:
##########
@@ -255,8 +257,13 @@ def build(
annotated_mods, target_host =
Target.canon_target_map_and_host(annotated_mods, target_host)
- # TODO(mbs): CompilationConfig implements the same host target defaulting
logic, but
- # tir_to_runtime currently bypasses that.
+ # TODO(mbs): Both CompilationConfig and TIRToRuntime implement the same
host target
+ # defaulting logic, but there's currently no way to get back the decided
host.
+ if target_host is not None:
+ warnings.warn(
+ "target_host parameter is going to be deprecated. "
+ "Please pass in tvm.target.Target(target, host=target_host)
instead."
+ )
Review Comment:
@mbs-octoml
In `ConstantFold pass`, `target_host` is always not None.(host is not None)
So warning message is printed on build time.
I think the above meg is not intended to warn the target made in internal
pass.
I am not perfectly understand `canon_target_map_and_host`,
So could you check this code block in constantFold pass
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
