guberti commented on code in PR #12641:
URL: https://github.com/apache/tvm/pull/12641#discussion_r958767232
##########
python/tvm/micro/testing/evaluation.py:
##########
@@ -151,7 +152,8 @@ def predict_labels_aot(session, aot_executor, input_data,
runs_per_sample=1):
assert aot_executor.get_num_outputs() == 1
assert runs_per_sample > 0
- for sample in input_data:
+ for counter, sample in enumerate(input_data):
+ logging.info("Evaluating sample %d", counter)
Review Comment:
I just learned the `logging` module has an optimization where it won't do
the string templating if logging is disabled, which improves efficiency (see
[the docs](https://docs.python.org/3.10/howto/logging.html#optimization)). I'm
a big fan of f-strings as well, but you're probably right that they don't make
sense here :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
