wrongtest-intellif commented on PR #12652: URL: https://github.com/apache/tvm/pull/12652#issuecomment-1232323999
LGTM. Here are my remaining some questions: 1. Since now we have `decl_buffer` node, if we also convert `T.alloc_buffer` to `T.decl_buffer` + `T.allocate` in `LowerOpaqueBlock`, could the `axis_separators` get preserved? (I am not so familiar with it, but I notice that it is in the Buffer object's field). Maybe then the order of the two passes could get totally free. Our team rely on the IR form which is block-free but multi-dimensional buffer accessing to perform certain analysis and rewriting, thus prefer to lower block before flatten in a customized configuration. 2. Do we have some protection case for the axis_separators feature? It seems #12172 passes without recognizing the introduced issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
