sunggg commented on code in PR #12628:
URL: https://github.com/apache/tvm/pull/12628#discussion_r959619205
##########
include/tvm/meta_schedule/database.h:
##########
@@ -357,6 +357,22 @@ class Database : public runtime::ObjectRef {
*/
TVM_DLL static Database JSONDatabase(String path_workload, String
path_tuning_record,
bool allow_missing);
+ /*!
+ * \brief A database composed of multiple databases, allowing users to guide
IR rewriting using
+ * combined knowledge of those databases. To each query, it returns the best
record among all the
+ * databases given.
+ * \param databases The list of databases to be combined.
+ * \return The combined database.
+ */
+ TVM_DLL static Database UnionDatabase(Array<Database, void> databases);
Review Comment:
When I saw `UnionDatabase` and `OrderedUnionDatabase`, I initially thought
the opposite: I thought `OrderedUnionDatabase` sorts tuning records and returns
the best one lol
This might be because I usually assign the name without prefix
"Ordered/Sorted" by considering "unsorted" as default. I guess this is a matter
of preference, so wonder how other folks think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
