driazati commented on code in PR #12644:
URL: https://github.com/apache/tvm/pull/12644#discussion_r959709979
##########
ci/jenkins/Build.groovy.j2:
##########
@@ -259,6 +259,25 @@ stage('Build') {
Utils.markStageSkippedForConditional('BUILD: RISC-V')
}
},
+ 'BUILD: CSINN2': {
+ if (!skip_ci && is_docs_only_build != 1) {
+ node('CPU-SMALL') {
+ ws({{ m.per_exec_ws('tvm/build-csinn2') }}) {
+ docker_init(ci_riscv)
+ init_git()
+ sh (
+ script: "${docker_run} ${ci_riscv}
./tests/scripts/task_config_build_csinn2.sh build-csinn2-x86 &&
+ ${docker_run} ${ci_riscv}
./tests/scripts/task_config_build_c906.sh build-csinn2-c906",
+ label: 'Create CSINN2 x86 and c906 cmake config',
+ )
+ make(ci_riscv, 'build-csinn2-x86', '-j2')
+ make(ci_riscv, 'build-csinn2-c906', 'tvm_rpc -j2')
Review Comment:
I pushed your changes to a branch in apache/tvm since that's the only way to
test these Jenkinsfile changes, it looks like there is a problem with the
newline here:
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/csinn_jenkins/1/pipeline/
I think this would fix it
```suggestion
script: "${docker_run} ${ci_riscv}
./tests/scripts/task_config_build_csinn2.sh build-csinn2-x86",
label: 'Create CSINN2 x86 cmake config',
)
make(ci_riscv, 'build-csinn2-x86', '-j2')
sh (
script: "${docker_run} ${ci_riscv}
./tests/scripts/task_config_build_c906.sh build-csinn2-c906",
label: 'Create CSINN2 c906 cmake config',
)
make(ci_riscv, 'build-csinn2-c906', 'tvm_rpc -j2')
```
##########
tests/scripts/task_config_build_csinn2.sh:
##########
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -euxo pipefail
+
+BUILD_DIR=$1
+mkdir -p "$BUILD_DIR"
+cd "$BUILD_DIR"
+cp ../cmake/config.cmake .
+
+echo set\(USE_RPC ON\) >> config.cmake
+echo set\(USE_LLVM llvm-config-10\) >> config.cmake
+echo set\(USE_OPENMP gnu\) >> config.cmake
+# echo set\(USE_CSINN "/opt/csi-nn2"\) >> config.cmake
Review Comment:
same here about the commented out code
##########
tests/scripts/task_config_build_c906.sh:
##########
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -euxo pipefail
+
+BUILD_DIR=$1
+mkdir -p "$BUILD_DIR"
+cd "$BUILD_DIR"
+cp ../cmake/config.cmake .
+
+echo set\(USE_CPP_RPC ON\) >> config.cmake
+echo set\(USE_LIBBACKTRACE OFF\) >> config.cmake
+# echo set\(USE_CSINN "/opt/csi-nn2"\) >> config.cmake
+# echo set\(USE_CSINN_DEVICE_RUNTIME C906\) >> config.cmake
Review Comment:
commented out code should be removed or have some context, I don't see
`USE_CSINN` in `CMakeLists.txt`, is there anything that needs to be done in the
build to enable CSI-NN2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
