driazati commented on code in PR #12131: URL: https://github.com/apache/tvm/pull/12131#discussion_r961872488
########## docker/install/ubuntu_install_tflite.sh: ########## @@ -38,8 +39,16 @@ pip3 install flatbuffers # The library is built at: # tensorflow/tensorflow/lite/tools/make/gen/*/lib/libtensorflow-lite.a. git clone https://github.com/tensorflow/tensorflow --branch=v${TENSORFLOW_VERSION} --depth 1 -./tensorflow/tensorflow/lite/tools/make/download_dependencies.sh -./tensorflow/tensorflow/lite/tools/make/build_lib.sh + +mkdir -p /opt/tflite +cd /opt/tflite +cmake \ + -DTFLITE_ENABLE_XNNPACK=OFF \ + /tensorflow/tensorflow/lite + +cmake --build . Review Comment: ```suggestion cmake --build . -- -j"$(nproc)" ``` ########## docker/install/ubuntu_install_cmake_source.sh: ########## @@ -20,8 +20,8 @@ set -e set -u set -o pipefail -v=3.14 -version=3.14.7 +v=3.22 Review Comment: does tflite require 3.22? #12682 is also trying to update the CMake version to 3.18 and we should pick the lower of the two for what runs in CI (if possible) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
