driazati commented on code in PR #12490:
URL: https://github.com/apache/tvm/pull/12490#discussion_r964409619
##########
tests/scripts/task_python_integration.sh:
##########
@@ -61,12 +61,16 @@ run_pytest cython
${TVM_INTEGRATION_TESTSUITE_NAME}-dso_plugin_module-1 apps/dso
run_pytest ctypes ${TVM_INTEGRATION_TESTSUITE_NAME}-integration
tests/python/integration
# Ignoring Arm(R) Ethos(TM)-U NPU tests in the collective to run to run them
in parallel in the next step.
-run_pytest ctypes ${TVM_INTEGRATION_TESTSUITE_NAME}-contrib
tests/python/contrib --ignore=tests/python/contrib/test_ethosu
--ignore=tests/python/contrib/test_cmsisnn
+run_pytest ctypes ${TVM_INTEGRATION_TESTSUITE_NAME}-contrib
tests/python/contrib --ignore=tests/python/contrib/test_ethosu
--ignore=tests/python/contrib/test_cmsisnn
--ignore=tests/python/contrib/test_opencl
# forked is needed because the global registry gets contaminated
TVM_TEST_TARGETS="${TVM_RELAY_TEST_TARGETS:-llvm;cuda}" \
run_pytest ctypes ${TVM_INTEGRATION_TESTSUITE_NAME}-relay
tests/python/relay
+# OpenCL texture test. Deselected specific tests that fails in CI
+TVM_TEST_TARGETS="${TVM_RELAY_OPENCL_TEXTURE_TARGETS:-opencl}" \
+ run_pytest ctypes ${TVM_INTEGRATION_TESTSUITE_NAME}-opencl-texture
tests/python/relay/opencl_texture
--deselect=tests/python/relay/opencl_texture/test_conv2d_nchw_texture.py::test_residual_block
Review Comment:
Instead of deselecting here can you:
1. File a GitHub issue with the test name and some context on why it fails
with OpenCL
2. Move the skipping to the test itself via
[`pytest.mark.skipIf`](https://docs.pytest.org/en/7.1.x/how-to/skipping.html)
and be sure to add a `reason="See <link to apache/tvm GitHub issue>"`?
That might make it so you don't need to change this script at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
