vvchernov commented on code in PR #11358:
URL: https://github.com/apache/tvm/pull/11358#discussion_r966850057
##########
include/tvm/runtime/vm/vm.h:
##########
@@ -339,6 +371,51 @@ class TVM_DLL VirtualMachine : public runtime::ModuleNode {
void SetInputTensorWithIndex(std::vector<ObjectRef>& tensors, // NOLINT(*)
const TVMArgValue& tensor, int index, Device
dev);
+ /*!
+ * \brief Convert tensor from TVMArgValue to ObjectRef.
+ * DLTensor and NDArray types are supported.
+ * \param tensor given arg value containing tensor.
+ * \return tensor in ObjectRef format
+ */
+ ObjectRef TensorFromTVMArgValueToObjectRef(const TVMArgValue& tensor) const;
+
+ /*!
+ * \brief Get index of outputs in register_file from func code
+ * \return result register index
+ */
+ Index GetResultRegisterIndex() const;
+
+ /*!
+ * \brief Calculate the index of operation which destination is result
+ * \param res_index is the index of op returning result
+ */
+ void CalculatePreResultOpIndex(Index res_index);
+
+ /*!
+ * \brief Collect indices from register_file for output tensors.
+ * It helps to replace output tensors allocated in RunLoop by
+ * tensors pre-allocated outside. Scenario is when `set_output` is used
+ * \param func_name The function's name.
+ */
+ void CollectOutputTensorRegIndices(const std::string& func_name);
Review Comment:
I've refactored it, but I think the main reason of the problem stays. It is
func name role. I do not know somebody uses anything except "main" I did not. I
do not know the idea of func name and main thing is code_ does not depend on
func name, but RunLoop depends on code_ only. Thus I can assume that using of
two func names in front-end leads to error or unexpected behaviour. Looks like
that VM design is still raw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
