Hzfengsy commented on code in PR #12766:
URL: https://github.com/apache/tvm/pull/12766#discussion_r970292569
##########
tests/python/unittest/test_tir_schedule_cache_read_write.py:
##########
@@ -414,15 +432,15 @@ def cache_read_multi_consumer_target() -> None:
with T.block("A"):
vi = T.axis.S(128, i * 16 + j)
A[vi] = 1.0
- for j in T.grid(16):
- with T.block("A"):
- vi = T.axis.S(128, i * 16 + j)
- A_global[vi] = A[vi]
for j in T.grid(16):
with T.block("B"):
vi = T.axis.S(128, i * 16 + j)
B[vi] = A[vi] + 1.0
+ for i in T.grid(128):
Review Comment:
Why do we need to change this testcase? A common practice is not to change
the existing test case if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
