manupak commented on code in PR #12731:
URL: https://github.com/apache/tvm/pull/12731#discussion_r970760561
##########
python/tvm/relay/backend/contrib/uma/backend.py:
##########
@@ -278,7 +278,7 @@ def register(self) -> None:
"""
registration_func =
tvm.get_global_func("relay.backend.contrib.uma.RegisterTarget")
- for name, attr in self._target_attrs:
+ for name, attr in self._target_attrs.items():
Review Comment:
Maybe because this was too generic (though I expect that to be some sort of
TypeError) :
https://github.com/apache/tvm/blob/2aa0d1fbfcf4a31e343cc6852fdc4abd660c850a/tests/python/contrib/test_uma/test_target.py#L72.
Should we make sure that we catch the correct exception ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
