junrushao commented on code in PR #12786:
URL: https://github.com/apache/tvm/pull/12786#discussion_r972277667


##########
include/tvm/script/ir_builder/tir/frame.h:
##########
@@ -187,6 +187,51 @@ class BlockFrame : public TIRFrame {
   TVM_DEFINE_MUTABLE_NOTNULLABLE_OBJECT_REF_METHODS(BlockFrame, TIRFrame, 
BlockFrameNode);
 };
 
+/*!
+ * \brief A frame that represents the for loop.
+ *
+ * \sa BlockInitFrame
+ */
+class ForFrameNode : public TIRFrameNode {
+ public:
+  /*! \brief The for loop generating function type. */
+  using FMakeForLoop =
+      runtime::TypedPackedFunc<tvm::tir::Stmt(Array<tvm::tir::Var>, 
Array<Range>, tvm::tir::Stmt)>;

Review Comment:
   ```suggestion
     /*!
      * \brief Functions that generate loop nests.
      * \param loop_vars The loop variables, from outer to inner
      * \param loop_extents The loop extents that correspond to loop variables
      * \param loop_body The loop body
      * \return A stmt, the loop nest
      */
     using FMakeForLoop =
         runtime::TypedPackedFunc<tvm::tir::Stmt(Array<tvm::tir::Var> 
loop_vars, Array<Range> loop_extents, tvm::tir::Stmt loop_body)>;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to