zhangyicole commented on PR #12761: URL: https://github.com/apache/tvm/pull/12761#issuecomment-1248891229
> It would be useful to make it as a different equality comparator (rather than change DeepEqual's behavior, e.g. we can do CommunicativeDeepEqual as a subclass), as communicative rewrite is something that goes deeper. > > Another possibility is add a canonicalization pass to canonicalize the expressions before CSE Hi，@tqchen，Thanks a lot for the review! I agree that it would be useful to make it as a different equality comparator， this will not have an impact on TVM's infrastructure. So how about making it a new subclass, as you suggested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
