Lunderberg commented on PR #12822: URL: https://github.com/apache/tvm/pull/12822#issuecomment-1251472309
Looking through it again, I think the move constructor only makes sense in cases where it is legal to exit scopes in something other than the reverse order of entering scopes. For most use cases I could see (e.g. maintaining a stack of a current value), the order of destruction shouldn't be allowed to vary. My concern was primarily that the implicitly generated copy/move constructors would result in incorrect behavior, and to remove that failure mode. Disabling the move constructor altogether serves this same purpose, so I can update the PR to instead disable the automatically-generated move constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
