driazati commented on code in PR #12833:
URL: https://github.com/apache/tvm/pull/12833#discussion_r975867038
##########
docker/bash.sh:
##########
@@ -453,6 +453,12 @@ if [ -f "${REPO_DIR}/.git" ]; then
fi
fi
+if [[ "${DOCKER_IMAGE_NAME}" == *"ci_adreno"* && ! -z "${ADRENO_OPENCL}" ]];
then
+ DOCKER_MOUNT+=( --volume ${ADRENO_OPENCL}:/adreno-opencl)
+ DOCKER_ENV+=( --env ADRENO_OPENCL=/adreno-opencl )
+ DOCKER_ENV+=( --net=host)
Review Comment:
it looks like net=host gets turned on already:
https://github.com/apache/tvm/blob/52dbf102cdba1186e517977ee02aaa7bbe46d0df/docker/bash.sh#L346
i’d prefer we avoid setting it automatically like this so it didn’t get
enabled accidentally in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
