mehrdadh commented on code in PR #12818:
URL: https://github.com/apache/tvm/pull/12818#discussion_r976941031
##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -368,43 +436,33 @@ def _get_platform_version(self, arduino_cli_path: str) ->
float:
return version.parse(str_version)
# This will only be run for build and upload
- def _check_platform_version(self, options):
+ def _check_platform_version(self, arduino_cli_cmd: str, warning_as_error:
bool):
Review Comment:
that makes sense, I moved `_get_arduino_cli_cmd` call in the high-level
function
##########
python/tvm/micro/project_api/server.py:
##########
@@ -759,6 +764,68 @@ def write_with_timeout(fd, data, timeout_sec): # pylint:
disable=invalid-name
return num_written
+def default_project_options(**kw) -> typing.List[ProjectOption]:
+ """Get default Project Options
+
+ Attributes of any default option can be updated. Here is an example
+ when attribute `optional` from `verbose` option needs to be updates:
+
+ default_project_options(verbose={"optional": ["build"]})
+
+ This will update the `optional` attribute of `verbose` ProjectOption
+ to be `["build"]`.
+
+ Returns
+ -------
+ options: List[ProjectOption]
+ A list of default ProjectOption with modifications.
+ """
+ options = [
+ ProjectOption(
+ "verbose",
+ optional=["generate_project"],
+ type="bool",
+ help="Run build with verbose output.",
+ ),
+ ProjectOption(
+ "project_type",
+ required=["generate_project"],
+ type="str",
+ help="Type of project to generate.",
+ ),
+ ProjectOption(
+ "board",
+ required=["generate_project"],
+ type="str",
+ help="Name of the board to build for.",
+ ),
+ ProjectOption(
+ "cmsis_path",
+ optional=["generate_project"],
+ type="str",
+ help="Path to the CMSIS directory.",
+ ),
+ ProjectOption(
+ "warning_as_error",
+ optional=["generate_project"],
+ type="bool",
+ default=False,
+ help="Treat warnings as errors and raise an Exception.",
+ ),
+ ]
+ for name, config in kw.items():
+ option_found = False
+ for ind, option in enumerate(options):
+ if option.name == name:
+ options[ind] = option.replace(config)
+ option_found = True
+ break
+ if not option_found:
+ raise ValueError("Option {} was not found in default
ProjectOptions.".format(name))
Review Comment:
that doesn't work because the `kw` is a list of suggested changes but option
has ProjectOption type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
