lhutton1 commented on code in PR #12887:
URL: https://github.com/apache/tvm/pull/12887#discussion_r981318065
##########
tests/python/contrib/test_ethosn/test_addition.py:
##########
@@ -117,13 +119,15 @@ def test_addition(dtype, shape):
@requires_ethosn
@pytest.mark.parametrize("dtype", ["uint8", "int8"])
@pytest.mark.parametrize(
- "lhs_shape,rhs_shape",
+ "lhs_shape,lhs_is_constant,rhs_shape,rhs_is_constant",
[
- ((1, 4, 4, 8), (1, 1, 1, 8)),
- ((1, 16, 12, 4), (4,)),
+ ((1, 4, 4, 8), False, (1, 1, 1, 8), True),
+ ((4,), True, (1, 16, 12, 4), False),
+ ((1, 1, 1, 8), True, (1, 4, 4, 8), False),
+ ((1, 16, 12, 4), False, (4,), True),
Review Comment:
see above - I'm of the opinion we should block this PR though as it doesn't
add the const+const functionality. A test for this case should be added in a
separate PR though, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
