tqchen commented on PR #12942: URL: https://github.com/apache/tvm/pull/12942#issuecomment-1262596419
Thanks @Lunderberg . RewriteSimplifier is in the heart of a lot of things, so changes to this module should be done with extra amount of care. For example, in some of our cases we have recursive calls into simplify that further triggers other rewrite simplifications of the expressions within the boolean expr (`TVM_TRY_RECURSIVE_REWRITE`), so refactoring booleaning simplfication into a separate function may not retain that deep recursive behavior. We can see the values of introducing boolean simplification as being described. For extra caution, it might be helpful to simply introduce a bit of duplication of rules and have an independent implementation here. Since SimplifyBooleanOps are used in more limited cases. Additionally, is it OK to simply invoke the full simplification instead? It might be useful to discuss the usecase scenarios to see if we can also retrofit to some of existing simplifiers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
