tmoreau89 commented on code in PR #12954:
URL: https://github.com/apache/tvm/pull/12954#discussion_r986037292
##########
tests/python/contrib/test_hexagon/test_software_pipeline_async.py:
##########
@@ -46,18 +47,33 @@ def plus_one_ref(a):
return plus_one_primfunc, plus_one_ref
[email protected]_hexagon
-def test_software_pipeline_with_cache_read(hexagon_launcher, compute, outer,
inner, dtype, scope):
[email protected]
+def schedule(compute, sched, scope):
sch = tir.Schedule(compute[0])
- root = sch.get_block("root")
+
compute_block = sch.get_block("compute")
cache_read_block = sch.cache_read(compute_block, 0, scope)
i, _ = sch.get_loops(compute_block)
sch.compute_at(cache_read_block, i)
- sch.annotate(i, "software_pipeline_stage", [0, 1])
- sch.annotate(i, "software_pipeline_order", [0, 1])
- sch.annotate(i, "software_pipeline_async_stages", [0])
+
+ if sched == "cache_read":
Review Comment:
Does it make sense for the sake of completeness to test a cache_write
pipeline where `sch.annotate(i, "software_pipeline_async_stages", [1])`?
##########
tests/python/contrib/test_hexagon/test_software_pipeline_async.py:
##########
@@ -46,18 +47,33 @@ def plus_one_ref(a):
return plus_one_primfunc, plus_one_ref
[email protected]_hexagon
-def test_software_pipeline_with_cache_read(hexagon_launcher, compute, outer,
inner, dtype, scope):
[email protected]
Review Comment:
is `requires_hexagon` now implicit?
##########
tests/python/contrib/test_hexagon/test_software_pipeline_async.py:
##########
@@ -26,8 +26,9 @@
outer = tvm.testing.parameter(8, 16)
inner = tvm.testing.parameter(64, 128)
-scope = tvm.testing.parameter("global", "global.vtcm")
dtype = tvm.testing.parameter("uint8", "float16")
+scope = tvm.testing.parameter("global", "global.vtcm")
+sched = tvm.testing.parameter("cache_read", "cache_read_write")
@tvm.testing.fixture
Review Comment:
With this PR, we could technically test any n-stage pipeline, correct
(doesn't have to be limited to 3-stage)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
