Lunderberg commented on code in PR #12863:
URL: https://github.com/apache/tvm/pull/12863#discussion_r989382211
##########
include/tvm/arith/analyzer.h:
##########
@@ -275,6 +275,36 @@ class RewriteSimplifier {
*/
std::function<void()> EnterConstraint(const PrimExpr& constraint);
+ /*! \brief Flags to enable more computationally-intensive simplifications
+ *
+ * These simplifications may be required for specific schedules, but
+ * would impose too high a compile-time cost to enable by default.
+ * They can be enabled on an as-needed basis by calling
+ * `RewriteSimplifier::SetEnabledFeatures` prior to using
+ * `RewriteSimplifier::operator()`.
+ */
+ enum Feature {
Review Comment:
I like that wording much more than `Feature`. Updated here, and in all
other occurrences in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
