jwfromm commented on PR #12978: URL: https://github.com/apache/tvm/pull/12978#issuecomment-1273822366
I see, so to summarize the concern is that there may be untested behaviors of the current parser that users rely on in external codebases but adding more tests pre-migration reduces the odds of this. Although its not clear to me that its worth delaying this PR for, the argument does make sense. However, it only would work if we expect the test suite to pass on main today. @junrushao is that the case or does the new test suite rely on features being introduced by this work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
