ashutosh-arm commented on code in PR #13022:
URL: https://github.com/apache/tvm/pull/13022#discussion_r992580396
##########
src/runtime/contrib/ethosn/ethosn_device.cc:
##########
@@ -123,21 +133,26 @@ bool Inference(tvm::runtime::TVMArgs args, dl::Network*
npu,
}
// Execute the inference.
- std::unique_ptr<dl::Inference> result(
+ std::unique_ptr<dl::Inference> inference(
npu->ScheduleInference(ifm_raw, n_inputs, ofm_raw, n_outputs));
- bool inferenceCompleted = WaitForInference(result.get(), 60);
- if (inferenceCompleted) {
- for (size_t i = 0; i < n_outputs; i++) {
- DLTensor* tensor = outputs[i];
- dl::Buffer* source_buffer = ofm_raw[i];
- uint8_t* dest_buffer = static_cast<uint8_t*>(tensor->data);
- size_t size = source_buffer->GetSize();
- uint8_t* source_buffer_data = source_buffer->Map();
- std::copy(source_buffer_data, source_buffer_data + size, dest_buffer);
- source_buffer->Unmap();
- }
+ WaitStatus result = WaitForInference(inference.get(), 60);
Review Comment:
nit: seems like something that should be a knob (in future) - wdyt?
##########
tests/cpp/runtime/contrib/ethosn/inference_test.cc:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tests/cpp/runtime/contrib/ethosn/inference_test.cc
+ * \brief Tests to check runtime components used during inference.
Review Comment:
nit: this is specific to npu, so it would be worthwhile noting down the name.
##########
tests/cpp/runtime/contrib/ethosn/inference_test.cc:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tests/cpp/runtime/contrib/ethosn/inference_test.cc
+ * \brief Tests to check runtime components used during inference.
+ */
+
+#ifdef ETHOSN_HW
+
+#include <gtest/gtest.h>
+
+#include "../../../../../src/runtime/contrib/ethosn/ethosn_device.cc"
+
+namespace tvm {
+namespace runtime {
+namespace ethosn {
+
+TEST(WaitForInference, FailedResultRead) {
+ const int inference_error = 3;
+ const int timeout = 0;
+ dl::Inference inference = dl::Inference(inference_error);
+ WaitStatus result = WaitForInference(&inference, timeout);
+
+ ASSERT_EQ(result.GetErrorCode(), WaitErrorCode::Error);
+ ICHECK_EQ(result.GetErrorDescription(),
+ "Failed to read inference result status (No such file or
directory)");
+}
+
+TEST(WaitForInference, InferenceTimeout) {
+ const int inference_scheduled = 0;
+ const int timeout = 0;
+ dl::Inference inference = dl::Inference(inference_scheduled);
Review Comment:
just curious why we don't have tests for other inputs except 0 and 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
