AndrewZhaoLuo commented on code in PR #13056:
URL: https://github.com/apache/tvm/pull/13056#discussion_r993939468
##########
src/relay/transforms/simplify_expr.cc:
##########
@@ -146,7 +146,7 @@ class SimplifyConsecutiveCast : public DFPatternRewrite {
// BFloat cast cannot be omitted
return false;
}
- if (origin.code() < cast.code()) {
+ if (origin.code() < cast.code() && origin.bits() <= cast.bits()) {
Review Comment:
But I think it's a bigger issue. I think PR is at least slightly better and
safer than before so will approve. Will make a reminder to open issue here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
