yelite commented on code in PR #13061:
URL: https://github.com/apache/tvm/pull/13061#discussion_r994602762
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType =
"round-robin",
space: ms.SpaceGenerator.SpaceGeneratorType = "post-order-apply",
strategy: ms.SearchStrategy.SearchStrategyType = "replay_trace",
Review Comment:
```suggestion
strategy: ms.SearchStrategy.SearchStrategyType = "replay-trace",
```
There is a typo here in the original code
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType =
"round-robin",
Review Comment:
I am thinking about putting `TaskScheduler` into the `ms` module. I cannot
find the reason that `TaskScheduler` doesn't belong to the top level
`meta_schedule` module like other classes do. @junrushao Your thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
