supersat opened a new pull request, #13072: URL: https://github.com/apache/tvm/pull/13072
Currently Hexagon logging is done with a custom `LogMessageImpl` in` hexagon_common.cc`. This ends up calling `HexagonLog `and `HEXAGON_PRINT` which uses the HAP FARF API. Unfortunately, the TVM log level is lost along the way, with logs being produced at FARF’s `ALWAYS` level. This becomes especially noisy with RPC debug logging, which generates enough noise to cause some log data to be dropped. It also introduces a lot of useless noise, as the FARF API produces its own line number information, which only points to where `hexagon_common.cc` calls `HEXAGON_PRINT`. Using the `HAP_debug_runtime` API lets us pass the log level and file line information directly, and enables runtime selection of logging levels. This commit explicitly passes the log level to `LogMessage`/`LogMessageImpl` and updates Hexagon's custom `LogMessageImpl` to use the `HAP_debug_runtime` API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
