tkonolige commented on code in PR #13003: URL: https://github.com/apache/tvm/pull/13003#discussion_r995201406
########## python/tvm/utils/roofline/registry.py: ########## @@ -15,18 +15,24 @@ # specific language governing permissions and limitations # under the License. """Definition of generic functions for estimating peak flops and bandwidth""" -from typing import Optional -from ...target import Target, generic_func -from ...runtime import Device +from typing import Dict, Optional, Tuple + +import numpy as np + from ...rpc.client import RPCSession +from ...runtime import Device +from ...target import Target, generic_func +from ...tir import PrimFunc @generic_func def estimate_peak_bandwidth( + func: PrimFunc, Review Comment: You might want to dispatch to different peak measurements based on the features or the primfunc. For example, I could detect if tensorcores could be used with the given primfunc or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
