adstraw commented on code in PR #13109:
URL: https://github.com/apache/tvm/pull/13109#discussion_r998707266
##########
src/runtime/hexagon/hexagon_device_api.cc:
##########
@@ -167,10 +149,7 @@ void* HexagonDeviceAPI::AllocWorkspace(Device dev, size_t
size, DLDataType type_
void HexagonDeviceAPI::FreeWorkspace(Device dev, void* data) {
CHECK(IsValidDevice(dev)) << "dev.device_type: " << dev.device_type;
- CHECK(runtime_hexbuffs) << "Attempted to free Hexagon workspace with "
- << "HexagonDeviceAPI::FreeWorkspace outside of a
session. "
- << "Please call HexagonDeviceAPI::AcquireResources";
- CHECK(runtime_hexbuffs->count(data) != 0)
+ CHECK(runtime_hexbuffs.count(data) != 0)
Review Comment:
I think this check is redundant to what's already done in the
`FreeHexagonBuffer` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
