masahi commented on code in PR #13084:
URL: https://github.com/apache/tvm/pull/13084#discussion_r998807081
##########
src/meta_schedule/utils.h:
##########
@@ -318,14 +318,16 @@ struct ThreadedTraceApply {
for (int i = 0; i < n_; ++i) {
Item& item = items_[i];
+ bool applied = false;
try {
- if (!item.postproc->Apply(sch)) {
- ++item.fail_counter;
- return NullOpt;
+ if (item.postproc->Apply(sch)) {
+ applied = true;
}
} catch (const std::exception& e) {
- // Used in multi-thread, only output to screen but failure summary
sent to logging
- LOG(WARNING) << "ThreadedTraceApply::Apply failed with error " <<
e.what();
+ // left blank intentionally
Review Comment:
"Benign" failures should be caught at the postproc level, e.g. this is how
the error is handled for auto tensorization
https://github.com/apache/tvm/blob/02c2eae510d6d6c15189427c97819f7ce05f002d/src/meta_schedule/postproc/rewrite_tensorize.cc#L43-L46.
Other errors that propagate to `ThreadedTraceApply` level should be treated
as a bug in MS. So I think it is ok to remove this log or this try /catch
entirely, and let it crash to reveal the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
