janetsc commented on code in PR #13139:
URL: https://github.com/apache/tvm/pull/13139#discussion_r999711311
##########
src/runtime/hexagon/hexagon_device_api.h:
##########
@@ -79,8 +78,7 @@ class HexagonDeviceAPI final : public DeviceAPI {
CHECK(runtime_hexbuffs) << "runtime_hexbuffs was not created in
AcquireResources";
if (!runtime_hexbuffs->empty()) {
- DLOG(INFO) << "runtime_hexbuffs was not empty in ReleaseResources";
- released_runtime_buffers = runtime_hexbuffs->current_allocations();
+ LOG(INFO) << "runtime_hexbuffs was not empty in ReleaseResources";
Review Comment:
The only downside to moving it is that we won't know which buffer manager
had allocations when it was released. There is a buffer manager for memory
associated with thread management, for example. This one is only for client
buffers within a session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
