sunggg commented on PR #95: URL: https://github.com/apache/tvm-rfcs/pull/95#issuecomment-1284437870
Thank you for sharing your thoughts, @areusch. I think it might be helpful for better discussion if you can clarify a little further especially about your main concern (2nd one). Particularly, I want to hear more about your thoughts on the following things: 1. Are you suggesting the consensus is the right way to go for this optional module? If so, I'm wondering how you define the consensus. IMHO, reaching unanimous might be practically impossible for the large community like this and it does not seem to fit for S0: by definition, S0 is to satisfy clear needs from some users in the community, not the entire users. I'm afraid if too high bar for optional module may discourage contributors. 2. This quote below sounds more about the standard process of how we digest a giant commit, which could be orthogonal to voting rules. IIUC, this seems like the process of integration after the vote of deciding whether community members want to accept the proposed optional module or not. Personally, I believe voting should be based on the idea or proposal rather than the code size. > They might create a giant merge commit, or a 20,000-line commit that isn't reviewed according to the project's standards. Such large changes are often so disruptive to a project as to influence the project's overall direction and, in turn, its community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
