Mousius commented on code in PR #12455:
URL: https://github.com/apache/tvm/pull/12455#discussion_r1001995319


##########
tests/python/contrib/test_arm_compute_lib/test_network.py:
##########
@@ -180,7 +183,12 @@ def get_model():
         return mod, params, inputs
 
     _build_and_run_network(
-        *get_model(), device=device, tvm_ops=3, acl_partitions=30, atol=9, 
rtol=0
+        *get_model(),
+        device=device,
+        tvm_ops=3,
+        acl_partitions=30,
+        atol=9,
+        rtol=0.01,

Review Comment:
   I guess the alternative would be to change `atol` slightly as it checks 
against `atol + rtol * abs(desired)` 
(https://numpy.org/doc/stable/reference/generated/numpy.testing.assert_allclose.html)
   
   I've just tried it again locally though and it isn't failing... which is 
kinda sus, potentially one of the other fixes means the schedule is back to 
being a bit closer 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to