mehrdadh commented on code in PR #13072:
URL: https://github.com/apache/tvm/pull/13072#discussion_r1002268481


##########
apps/ios_rpc/tvmrpc/TVMRuntime.mm:
##########
@@ -45,7 +45,8 @@
   throw tvm::runtime::InternalError(file, lineno, message);
 }
 
-void LogMessageImpl(const std::string& file, int lineno, const std::string& 
message) {
+void LogMessageImpl(const std::string& file, int lineno, int level, const 
std::string& message) {
+  // TODO: Output logging level

Review Comment:
   remove?



##########
src/runtime/hexagon/rpc/android_bash.sh.template:
##########
@@ -20,7 +20,18 @@ export LD_LIBRARY_PATH=.
 
 # Enable FARF-based logging for Hexagon code invoked by 
'tvm_rpc_android_server'.
 export ADSP_LIBRARY_PATH=`pwd`
-echo 0x1f > tvm_rpc_android.farf
+
+# Runtime log levels can be selectively enabled by computing a bitmask
+# corresponding to the levels you want to enable. These get forwarded to
+# logcat by the DSP RPC daemon. The bits for each level are:
+
+# 0x01 - Hexagon LOW / TVM DEBUG
+# 0x02 - Hexagon MEDIUM / TVM INFO
+# 0x04 - Hexagon HIGH / TVM WARN
+# 0x08 - Hexagon ERROR / TVM ERROR
+# 0x10 - Hexagon FATAL / TVM FATAL
+
+echo 0x1e > tvm_rpc_android.farf

Review Comment:
   can you add this to the HexagonLauncher so we will be able to set the debug 
level at the python level?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to