Lunderberg commented on code in PR #13081:
URL: https://github.com/apache/tvm/pull/13081#discussion_r1003498450
##########
tests/python/unittest/test_arith_canonical_simplify.py:
##########
@@ -97,6 +97,8 @@ def test_split_index_simplify():
# cannot simplify mixed case, unless we canonicalize into one mode.
ck.verify(tdiv(x, 6) * 2 + tmod(fld(x, 3), 2), tdiv(x, 6) * 2 +
tmod(fld(x, 3), 2))
+ ck.verify(tmod(-x, 2), tmod(x, -2) * -1)
Review Comment:
This test only covers the CanonicalSimplify behavior of negative indices,
but the ModularSet's behavior should be consistent with the sign convention in
CanonicalSimplify. Since CanonicalSimplify's sign convention for negative
indices wasn't checked by any test I could find, I wanted to add a test for its
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
