AndrewZhaoLuo commented on code in PR #13163:
URL: https://github.com/apache/tvm/pull/13163#discussion_r1003545805
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -5383,6 +5375,12 @@ def verify_eyelike(indata, dynamic=False):
]
}
+flaky_target_skips = {
Review Comment:
Yeah interesting, on
https://docs.nvidia.com/cuda/cuda-math-api/group__CUDA__MATH__DOUBLE.html#group__CUDA__MATH__DOUBLE_1g2316a104cfda8362208d52238181fbfb:
`__device__ double nearbyint ( double x )`
`Round argument x to an integer value in double precision floating-point
format. Uses round to nearest rounding, with ties rounding to even.`
So it sounds like the CUDA rounding is fixed to round to even. This is odd
because this is not a mode for the std::nearbyintf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
