janetsc commented on code in PR #13181:
URL: https://github.com/apache/tvm/pull/13181#discussion_r1005023373
##########
src/runtime/hexagon/hexagon_thread_manager.cc:
##########
@@ -168,7 +180,8 @@ void HexagonThreadManager::SpawnThreads(unsigned
thread_stack_size_bytes,
next_stack_start += thread_stack_size_bytes;
// create the thread
- contexts_[i] = new ThreadContext(&pipes_[i], i);
+ contexts_[i] = new ThreadContext(&pipes_[i], i, hw_resources_.empty() ?
NONE : hw_resources_[i],
+ hvx_.get(), htp_.get());
Review Comment:
I construct on the global thread. I use the pointers to the object to then
call Lock() on the actual threads. I plan to keep it like that since we have
one context for "reserving," but then multiple threads can "lock."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]