csullivan commented on code in PR #13243:
URL: https://github.com/apache/tvm/pull/13243#discussion_r1009903102
##########
src/meta_schedule/schedule_rule/multi_level_tiling_tensor_core.cc:
##########
@@ -556,6 +556,11 @@ ScheduleRule ScheduleRule::MultiLevelTilingTensorCore(
Optional<Integer> max_innermost_factor, Optional<Array<Integer>>
vector_load_lens,
Optional<Map<String, ObjectRef>> reuse_read, Optional<Map<String,
ObjectRef>> reuse_write,
bool use_software_pipeline) {
+ if (tile_binds.defined()) {
+ for (const String& tile_bind : tile_binds.value()) {
+ CHECK_NE(tile_bind, "threadIdx.x") << "Cannot bind to threadIdx.x when
using tensor core.";
+ }
+ }
Review Comment:
Does this check (along with existing tests) now cover the regression this
fixes? If not adding a test to protect against the regression in the future
will surely save you and others time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
