cconvey commented on PR #13270:
URL: https://github.com/apache/tvm/pull/13270#issuecomment-1301064723

   > Changes look OK, is there a way we can turn this warning into an error + 
ensure its tested in CI so they don't slip back in?
   
   Clang (and I assume gcc) lets you control this using variations of 
`-Werror*` and `-Wno-error*`.  (See 
[docs](https://clang.llvm.org/docs/UsersManual.html#options-to-control-error-and-warning-messages).)
   
   I don't know if the community would be keen on that change though, since TVM 
doesn't define a list of "supported" compiler versions.
   
   What I can say is that I'm now getting clean compilations of TVM using clang 
15.0.3, and none of the warnings I fixed was really that big a deal.  I.e., I 
only fixed them out of preference, not necessity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to