Lunderberg commented on code in PR #13267:
URL: https://github.com/apache/tvm/pull/13267#discussion_r1013209580
##########
src/tir/transforms/narrow_datatype.cc:
##########
@@ -187,6 +187,11 @@ class DataTypeVisitor final : public StmtExprVisitor {
arith::ConstIntBoundAnalyzer::BoundMapType bound_;
};
+#if __clang__
Review Comment:
Instead of suppressing the warning altogether, could we instead add a `using
Parent::VisitStmt_;` and `using Parent::VisitExpr_`? That would allow the
parent's virtual functions to participate in overload resolution, avoiding the
case that the warning is trying to catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
