mehrdadh commented on code in PR #13271:
URL: https://github.com/apache/tvm/pull/13271#discussion_r1014471259
##########
tests/python/contrib/test_hexagon/metaschedule_e2e/export_models.py:
##########
@@ -34,14 +37,16 @@ def export_resnet50_fp16():
mod, params = relay.frontend.from_pytorch(script_module, input_shapes)
mod = relay.transform.ToMixedPrecision("float16")(mod)
- with open("resnet50_fp16.json", "w") as fo:
- fo.write(tvm.ir.save_json(mod))
+ with open("resnet50_fp16.json", "w") as file:
+ file.write(tvm.ir.save_json(mod))
- with open("resnet50_fp16.params", "wb") as fo:
- fo.write(relay.save_param_dict(params))
+ with open("resnet50_fp16.params", "wb") as file:
+ file.write(relay.save_param_dict(params))
Review Comment:
I reversed them back to global variables, but made them capital.
##########
tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_fp16.py:
##########
@@ -44,14 +40,19 @@ def convert_conv2d_layout(mod, desired_layouts):
@pytest.mark.skip("End-to-end tuning is skipped on CI.")
@tvm.testing.requires_hexagon
def test_resnet50(hexagon_launcher):
+ """Test Resnet50."""
+ model_json = "resnet50_fp16.json"
+ target_llvm = tvm.target.Target("llvm")
+ target_hexagon = get_hexagon_target("v69")
+
if not os.path.exists(model_json):
pytest.skip(msg="Run python export_models.py first.")
- with open(model_json, "r") as fi:
- mod = tvm.ir.load_json(fi.read())
+ with open(model_json, "r") as file:
+ mod = tvm.ir.load_json(file.read())
- with open(model_params, "rb") as fi:
- params = relay.load_param_dict(fi.read())
+ with open("resnet50_fp16.params", "rb") as file:
Review Comment:
fixed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
