arina-grovety commented on code in PR #13212:
URL: https://github.com/apache/tvm/pull/13212#discussion_r1016380651
##########
src/relay/backend/contrib/ethosu/compiler_attrs.cc:
##########
@@ -56,6 +57,11 @@ struct EthosUCompilerConfigNode : public
tvm::AttrsNode<EthosUCompilerConfigNode
"The class of Arm(R) Ethos(TM)-U NPU; possible values =
{ethos-u55-32, ethos-u55-64, "
"ethos-u55-128, ethos-u55-256}")
.set_default("ethos-u55-256");
+ TVM_ATTR_FIELD(dump_npu_functions_coverage)
+ .describe(
+ "Whether info about ethosu partition for input module layers
should be dumped; "
+ "possible values for dump to console / file, respectively = {-,
<path_to_file>}")
+ .set_default("");
Review Comment:
Thanks @lhutton1, I agree with most of the suggestions.
As for the default value, there is a concern that if we write output to the
console by default, wouldn't that clutter up the output? Seems like the ability
to not get it if it's not needed would be handy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
